From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Wrap external callers to IPS state with appropriate locks Date: Tue, 25 Sep 2012 14:55:16 +0100 Message-ID: <453bf0$5rmqf2@azsmga001.ch.intel.com> References: <1348579509-32348-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id F07D99F73A for ; Tue, 25 Sep 2012 06:55:22 -0700 (PDT) In-Reply-To: <1348579509-32348-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 25 Sep 2012 14:25:09 +0100, Chris Wilson wrote: > Finishes commit 02d719562ef40483648b2cc46899d4a2ff5953bb > Author: Daniel Vetter > Date: Thu Aug 9 16:44:54 2012 +0200 > > drm/i915: properly guard ilk ips state > > The core functions were annotated with their locking requirements, but > we overlooked that they were exported, without any control over the > locking, to debugfs. So in order to enable debugfs to read the registers > without triggering sanity checks, we change the exported entry points to > properly take the required locks before calling the core routines. Pardon me, resent the wrong patch... -Chris -- Chris Wilson, Intel Open Source Technology Centre