From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm: avoid passing null pointer to memset Date: Wed, 10 Oct 2012 13:52:35 +0100 Message-ID: <453bf0$61c77n@azsmga001.ch.intel.com> References: <1349805046-4587-1-git-send-email-rodrigo.vivi@gmail.com> <1349812618-11518-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id DD53B9E760 for ; Wed, 10 Oct 2012 05:52:56 -0700 (PDT) In-Reply-To: <1349812618-11518-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, 9 Oct 2012 16:56:58 -0300, Rodrigo Vivi wrote: > When cmd isn't IOC_IN | IOC_OUT a null "kdata" goes to "memset", which dereferences it. > > v2: simpler version just using usize = 0 instead of allocating useless memory > > Signed-off-by: Rodrigo Vivi Presuming that coverity is smart enough not to complain about memcpy(NULL, src, 0), Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre