From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] xdrm/i915: Respect HW RC6 states availability Date: Fri, 26 Oct 2012 11:17:03 +0100 Message-ID: <453bf0$67t0u0@azsmga001.ch.intel.com> References: <84c8a88hfcj@orsmga001.jf.intel.com> <1351116315-1822-1-git-send-email-rodrigo.vivi@gmail.com> <20121024223101.000041b4@unknown> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 378009E7FD for ; Fri, 26 Oct 2012 03:17:51 -0700 (PDT) In-Reply-To: <20121024223101.000041b4@unknown> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 24 Oct 2012 22:31:01 -0700, Ben Widawsky wrote: > Rodrigo Vivi wrote: > I like the direction this patch is going but I think it does limit > people with knowledge might want to do (for instance, I ran with rc6 > on ILK just fine for quite a while). > > How about we use add_taint instead, and a printk with KERN_WARNING for > platforms which have known issues? Good suggestion. I will definitely try to remember to apply this in future. :) I don't see anything wrong with allowing people to shoot themselves in the foot (as they often have the habit of hitting the wrong one), just so long as we are clear that it is not the default for a very good reason. -Chris -- Chris Wilson, Intel Open Source Technology Centre