From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: Defer assignment of obj->gtt_space until after all possible mallocs Date: Wed, 21 Nov 2012 13:46:29 +0000 Message-ID: <453bf0$6ideb1@azsmga001.ch.intel.com> References: <1353503044-20343-1-git-send-email-chris@chris-wilson.co.uk> <20121121131134.GQ5854@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 50CA7E5BF4 for ; Wed, 21 Nov 2012 05:46:34 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 21 Nov 2012 14:27:06 +0100, Daniel Vetter wrote: > Ok, I now see what's going on. Can't we do the bind together with the > mappable bind, i.e. > > if (!has_global_mapping && (map_and_fenceable || !aliasing_ppgtt)) > i915_gem_gtt_bind_object() You can indeed do it that way, it just took up too many lines... Imo, I think we want to eventually push the i915_gem_gtt_bind_object() to the callers. (You'll see why later if we ever get the current 3.7 regression resolved.) -Chris -- Chris Wilson, Intel Open Source Technology Centre