From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/2] drm/i915: Warn if ring tail is not
	qword aligned
Date: Mon, 26 Nov 2012 16:25:47 +0000
Message-ID: <453bf0$6k5283@azsmga001.ch.intel.com>
References: <1353934099-18685-1-git-send-email-ville.syrjala@linux.intel.com>
	<1353934099-18685-3-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1708294414=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [143.182.124.21])
	by gabe.freedesktop.org (Postfix) with ESMTP id 9BEF0E6196
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 26 Nov 2012 08:25:53 -0800 (PST)
In-Reply-To: <1353934099-18685-3-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1708294414==
Content-Type: text/plain

On Mon, 26 Nov 2012 14:48:19 +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Ringbuffer tail pointer must be qword aligned. Warn if someone
> makes a mistake and forgets to pad the ring when the commands
> inserted into the ring don't align to qword naturally.

The assertion should be that we wrote precisely the number of dwords we
declared in intel_ring_begin(). Which is one of the important factors to
check whenever reviewing such code. This assertion (which should be a
BUG_ON) is no substitute for such review.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

--===============1708294414==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1708294414==--