From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: The hw does not support source offsets into a YUV linear fb Date: Tue, 18 Dec 2012 23:03:02 +0000 Message-ID: <453bf0$6unqdb@azsmga001.ch.intel.com> References: <1355871094-5502-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id C3F7CE6319 for ; Tue, 18 Dec 2012 15:03:17 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 18 Dec 2012 23:57:05 +0100, Daniel Vetter wrote: > On Tue, Dec 18, 2012 at 11:51 PM, Chris Wilson wrote: > > As we can only pass in the base address of the first plane, we can not > > control the offset into the subsampled chroma planes. This means that we > > cannot support a source offset into a YUV* linear framebuffer. However, > > for tiled framebuffers we can tell the hardware which pixels to read > > from. So if we see a source offset into a linear YUV framebuffer, report > > the invalid value back to userspace. > > > > Signed-off-by: Chris Wilson > > Aren't all the yuv formats we support packet planar? So I think we > should be able to support source offsets, as long as x is even ... > Probably not worth the bother though. Didn't seem to work, so I opted to just avoid the issue. -Chris -- Chris Wilson, Intel Open Source Technology Centre