From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: The hw does not support source
	offsets into a YUV linear fb
Date: Wed, 19 Dec 2012 12:03:09 +0000
Message-ID: <453bf0$6uvsn6@azsmga001.ch.intel.com>
References: <1355871094-5502-1-git-send-email-chris@chris-wilson.co.uk>
	<CAKMK7uHrkdx8ujh+oo5tFhs7EOVXd_JHOdRDOSNM-4OjJJDssg@mail.gmail.com>
	<20121219115612.GT29018@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0332677018=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id E5504E5ECE
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 19 Dec 2012 04:03:24 -0800 (PST)
In-Reply-To: <20121219115612.GT29018@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============0332677018==
Content-Type: text/plain

On Wed, 19 Dec 2012 13:56:12 +0200, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Tue, Dec 18, 2012 at 11:57:05PM +0100, Daniel Vetter wrote:
> > On Tue, Dec 18, 2012 at 11:51 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > As we can only pass in the base address of the first plane, we can not
> > > control the offset into the subsampled chroma planes. This means that we
> > > cannot support a source offset into a YUV* linear framebuffer. However,
> > > for tiled framebuffers we can tell the hardware which pixels to read
> > > from. So if we see a source offset into a linear YUV framebuffer, report
> > > the invalid value back to userspace.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> I can't see the original mail with the patch, where did it go?
> 
> > Aren't all the yuv formats we support packet planar?
> 
> No idea what packet planar means. All we currently support are packed
> formats. The problem is that our code doesn't handle fb->offsets[].
> 
> If you're talking about src_x,src_y then those do work, at least on my
> atomic branch. I don't remember changing the src_x/src_y related code
> that much (apart from adding proper clipping), so I'm fairly sure they
> should work in the upstream code as well.

They only work with a tiled source, as far as my investigation into the
current code revealed.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

--===============0332677018==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0332677018==--