All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Simon Barber <simon@devicescape.com>
Cc: David Kimdon <dwhedon@devicescape.com>,
	netdev@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Jiri Benc <jbenc@suse.cz>
Subject: Re: [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc
Date: Thu, 26 Oct 2006 04:04:28 +0200	[thread overview]
Message-ID: <454017AC.7010009@trash.net> (raw)
In-Reply-To: <C86180A8C204554D8A3323D8F6B0A29F018B54D4@dhost002-46.dex002.intermedia.net>

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Simon Barber wrote:
> Pfifo_fast does not make sense because the 802.11 qdisc already
> categorizes the frames based on DSCP. The better thing would be to
> extract the pfifo qdisc so that it does not require NET_SCHED, but this
> is more work.

This patch should be enough to use it without NET_SCHED. You could of
course also allow modular build.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1488 bytes --]

diff --git a/net/d80211/Kconfig b/net/d80211/Kconfig
index 0f07d41..2cb79c1 100644
--- a/net/d80211/Kconfig
+++ b/net/d80211/Kconfig
@@ -3,6 +3,7 @@ config D80211
 	select CRYPTO
 	select CRYPTO_ARC4
 	select CRYPTO_AES
+	select NET_SCH_FIFO
 	---help---
 	This option enables the hardware independent IEEE 802.11
 	networking stack.
diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index 8298ea9..1d8b0dc 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -40,6 +40,10 @@ config NET_SCHED
 	  The available schedulers are listed in the following questions; you
 	  can say Y to as many as you like. If unsure, say N now.
 
+config NET_SCH_FIFO
+	bool
+	default y if NET_SCHED=y
+
 if NET_SCHED
 
 choice
diff --git a/net/sched/Makefile b/net/sched/Makefile
index 0f06aec..ff2d6e5 100644
--- a/net/sched/Makefile
+++ b/net/sched/Makefile
@@ -4,7 +4,7 @@ #
 
 obj-y	:= sch_generic.o
 
-obj-$(CONFIG_NET_SCHED)		+= sch_api.o sch_fifo.o sch_blackhole.o
+obj-$(CONFIG_NET_SCHED)		+= sch_api.o sch_blackhole.o
 obj-$(CONFIG_NET_CLS)		+= cls_api.o
 obj-$(CONFIG_NET_CLS_ACT)	+= act_api.o
 obj-$(CONFIG_NET_ACT_POLICE)	+= act_police.o
@@ -14,6 +14,7 @@ obj-$(CONFIG_NET_ACT_MIRRED)	+= act_mirr
 obj-$(CONFIG_NET_ACT_IPT)	+= act_ipt.o
 obj-$(CONFIG_NET_ACT_PEDIT)	+= act_pedit.o
 obj-$(CONFIG_NET_ACT_SIMP)	+= act_simple.o
+obj-$(CONFIG_NET_SCH_FIFO)	+= sch_fifo.o
 obj-$(CONFIG_NET_SCH_CBQ)	+= sch_cbq.o
 obj-$(CONFIG_NET_SCH_HTB)	+= sch_htb.o
 obj-$(CONFIG_NET_SCH_HPFQ)	+= sch_hpfq.o

      parent reply	other threads:[~2006-10-26  2:04 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 22:04 [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc David Kimdon
2006-10-25 23:29 ` Patrick McHardy
2006-10-26  1:21   ` Patrick McHardy
2006-10-26  2:38     ` Jeff Garzik
2006-10-26  3:37       ` Simon Barber
2006-10-26  5:04         ` Jeff Garzik
2006-10-26  5:15           ` Simon Barber
2006-11-01 10:28             ` Jiri Benc
2006-11-01 14:20               ` John W. Linville
2006-11-01 18:31                 ` James Ketrenos
2006-11-02  0:30                   ` Jeff Garzik
2006-11-02  1:48                     ` d80211 merge (was Re: [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc) James Ketrenos
2006-11-02  2:55                       ` Jeff Garzik
2006-11-02  8:49                         ` cfg80211/nl80211/WE (was: Re: d80211 merge) Johannes Berg
2006-11-02  8:59                           ` cfg80211/nl80211/WE Jeff Garzik
2006-11-02 10:56                           ` cfg80211/nl80211/WE (was: Re: d80211 merge) Christoph Hellwig
2006-11-02 12:03                             ` Johannes Berg
2006-11-02 12:16                   ` [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc Christoph Hellwig
2006-11-02 14:05                     ` Jiri Benc
2006-11-02 14:18                       ` Christoph Hellwig
2006-11-02 14:32                         ` Johannes Berg
2006-11-02 14:41                           ` Jochen Friedrich
2006-11-02 14:45                           ` Christoph Hellwig
2006-11-02 15:02                             ` Johannes Berg
2006-11-02 16:38                             ` Simon Barber
2006-11-02 15:42                         ` Jiri Benc
2006-11-02 16:09                           ` Sven-Haegar Koch
2006-11-02 18:38                             ` Jiri Benc
2006-11-02 20:58                               ` Dan Williams
2006-11-02 21:27                               ` Simon Barber
2006-11-02 22:48                                 ` Stephen Hemminger
2006-11-02 23:15                                   ` Luis R. Rodriguez
2006-11-02 14:22                       ` Johannes Berg
2006-11-02 16:33                         ` [patch] d80211: use pfifo_qdisc_ops rather thand80211-specific qdisc Simon Barber
2006-11-02 16:43                           ` Johannes Berg
2006-11-02 22:34                             ` Stephen Hemminger
2006-11-02 22:56                               ` Johannes Berg
2006-11-03 19:23                                 ` [patch] d80211: use pfifo_qdisc_ops rather thand80211-specificqdisc Simon Barber
2006-11-03 19:29                                   ` Simon Barber
2006-11-03 19:39                                     ` John W. Linville
2006-11-03 23:07                                   ` Johannes Berg
2006-11-04  2:20                                     ` [patch] d80211: use pfifo_qdisc_ops ratherthand80211-specificqdisc Simon Barber
2006-11-02 14:06                     ` [patch] d80211: use pfifo_qdisc_ops rather than d80211-specific qdisc John W. Linville
2006-10-26  1:34   ` Simon Barber
2006-10-26  1:49     ` Patrick McHardy
2006-10-26  3:17       ` Simon Barber
2006-10-26  2:04     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454017AC.7010009@trash.net \
    --to=kaber@trash.net \
    --cc=dwhedon@devicescape.com \
    --cc=jbenc@suse.cz \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    --cc=simon@devicescape.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.