From: Dirk Behme <dirk.behme@googlemail.com>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] ARM: OMAP: Fix warning in omap-keypad
Date: Fri, 27 Oct 2006 18:29:21 +0200 [thread overview]
Message-ID: <454233E1.7060909@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
Fix warning
rivers/input/keyboard/omap-keypad.c: In function
'omap_kp_probe':
drivers/input/keyboard/omap-keypad.c:450: warning: 'row_idx'
is used uninitialized in this function
drivers/input/keyboard/omap-keypad.c:453: warning: 'col_idx'
is used uninitialized in this function
Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
[-- Attachment #2: omap_keypad_warning_patch.txt --]
[-- Type: text/plain, Size: 623 bytes --]
Index: linux-osk/drivers/input/keyboard/omap-keypad.c
===================================================================
--- linux-osk.orig/drivers/input/keyboard/omap-keypad.c
+++ linux-osk/drivers/input/keyboard/omap-keypad.c
@@ -317,7 +317,7 @@ static int __init omap_kp_probe(struct p
struct omap_kp *omap_kp;
struct input_dev *input_dev;
struct omap_kp_platform_data *pdata = pdev->dev.platform_data;
- int i, col_idx, row_idx, irq_idx, ret;
+ int i, col_idx = 0, row_idx = 0, irq_idx, ret;
if (!pdata->rows || !pdata->cols || !pdata->keymap) {
printk(KERN_ERR "No rows, cols or keymap from pdata\n");
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
reply other threads:[~2006-10-27 16:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454233E1.7060909@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.