All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@google.com>
To: Giridhar Pemmasani <pgiri@yahoo.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Andy Whitcroft <apw@shadowen.org>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: Slab panic on 2.6.19-rc3-git5 (-git4 was OK)
Date: Sun, 29 Oct 2006 07:21:45 -0800	[thread overview]
Message-ID: <4544C709.6070305@google.com> (raw)
In-Reply-To: <20061029124655.7014.qmail@web32408.mail.mud.yahoo.com>

>> I only skimmed through this briefly but it looks like due to
>> 52fd24ca1db3a741f144bbc229beefe044202cac __get_vm_area_node is passing
>> GFP_HIGHMEM to kmem_cache_alloc_node which is a no-no.
> 
> I haven't been able to reproduce this, although I understand why it happens:
> vmalloc allocates memory with
> 
> GFP_KERNEL | __GFP_HIGHMEM
> 
> and with git5, the same flags are passed down to cache_alloc_refill, causing
> the BUG. The following patch against 2.6.19-rc3-git5 (also attached as
> attachment, as this mailer may mess up inline copying) should fix it.

Thanks for the patch ... but more worrying is how this got broken.
Wasn't the point of having the -mm tree that patches like this went
through it for testing, and we avoid breaking mainline? especially
this late in the -rc cycle.

M.

WARNING: multiple messages have this Message-ID (diff)
From: "Martin J. Bligh" <mbligh@google.com>
To: Giridhar Pemmasani <pgiri@yahoo.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Andy Whitcroft <apw@shadowen.org>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: Slab panic on 2.6.19-rc3-git5 (-git4 was OK)
Date: Sun, 29 Oct 2006 07:21:45 -0800	[thread overview]
Message-ID: <4544C709.6070305@google.com> (raw)
In-Reply-To: <20061029124655.7014.qmail@web32408.mail.mud.yahoo.com>

>> I only skimmed through this briefly but it looks like due to
>> 52fd24ca1db3a741f144bbc229beefe044202cac __get_vm_area_node is passing
>> GFP_HIGHMEM to kmem_cache_alloc_node which is a no-no.
> 
> I haven't been able to reproduce this, although I understand why it happens:
> vmalloc allocates memory with
> 
> GFP_KERNEL | __GFP_HIGHMEM
> 
> and with git5, the same flags are passed down to cache_alloc_refill, causing
> the BUG. The following patch against 2.6.19-rc3-git5 (also attached as
> attachment, as this mailer may mess up inline copying) should fix it.

Thanks for the patch ... but more worrying is how this got broken.
Wasn't the point of having the -mm tree that patches like this went
through it for testing, and we avoid breaking mainline? especially
this late in the -rc cycle.

M.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-10-29 15:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-29  5:57 Slab panic on 2.6.19-rc3-git5 (-git4 was OK) Martin J. Bligh
2006-10-29  5:57 ` Martin J. Bligh
2006-10-29  6:58 ` Pekka Enberg
2006-10-29  6:58   ` Pekka Enberg
2006-10-29 12:46   ` Giridhar Pemmasani
2006-10-29 12:46     ` Giridhar Pemmasani
2006-10-29 15:21     ` Martin J. Bligh [this message]
2006-10-29 15:21       ` Martin J. Bligh
2006-10-29 15:53       ` Giridhar Pemmasani
2006-10-29 15:53         ` Giridhar Pemmasani
2006-10-29  7:05 ` Andrew Morton
2006-10-29  7:05   ` Andrew Morton
2006-10-29  9:17   ` Nick Piggin
2006-10-29  9:17     ` Nick Piggin
2006-10-29 20:53     ` Giridhar Pemmasani
2006-10-29 20:53       ` Giridhar Pemmasani
2006-10-29 17:47   ` Andy Whitcroft
2006-10-29 17:47     ` Andy Whitcroft
2006-10-29 22:59     ` Martin J. Bligh
2006-10-29 22:59       ` Martin J. Bligh
2006-10-30  1:19       ` Linus Torvalds
2006-10-30  1:19         ` Linus Torvalds
2006-10-30  9:53         ` Andy Whitcroft
2006-10-30  9:53           ` Andy Whitcroft
2006-10-30 15:35         ` Andy Whitcroft
2006-10-30 15:35           ` Andy Whitcroft
2006-10-30 15:47           ` Pekka Enberg
2006-10-30 15:47             ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4544C709.6070305@google.com \
    --to=mbligh@google.com \
    --cc=akpm@osdl.org \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=pgiri@yahoo.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.