All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: "Marek Vašut" <marek.vasut@gmail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] OMAP MMC fixes
Date: Sun, 29 Oct 2006 20:32:35 +0100	[thread overview]
Message-ID: <454501D3.2050009@gmail.com> (raw)
In-Reply-To: <200610282040.09413.marek.vasut@gmail.com>

Marek Vašut wrote:
> oops, sorry, I missed the previous patch ...

;)

To get it right: You used 1 << data->blksz in your patch. I 
think it should only be data->blksz without additional shift 
because shift is already included in data->blksz?

http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=blobdiff;h=5b9caa7978d34311839840243e38921255f6da4b;hp=74eaaee66de0e59532ba5655fddac5aaeea5ba08;hb=132919ba80ad207755fe271277bfefff865a54fe;f=drivers/mmc/mmc.c

So, do you think

http://linux.omap.com/pipermail/linux-omap-open-source/2006-October/008183.html

is correct?

Thanks

Dirk

      reply	other threads:[~2006-10-29 19:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-28 18:34 [PATCH] OMAP MMC fixes Marek Vašut
2006-10-28 18:40 ` Marek Vašut
2006-10-29 19:32   ` Dirk Behme [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454501D3.2050009@gmail.com \
    --to=dirk.behme@googlemail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=marek.vasut@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.