From: Jarrett Knauer <jrtknauer@gmail.com>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: Fixed extra indentation in qlget_get_stats()
Date: Mon, 10 Feb 2020 11:31:20 -0700 [thread overview]
Message-ID: <45451eb8-e6a9-2e7a-e2fd-680b31e38717@gmail.com> (raw)
In-Reply-To: <20200210043158.GA3258@f3>
On 2020-02-09 9:31 p.m., Benjamin Poirier wrote:
> On 2020/02/09 00:36 -0700, Jarrett Knauer wrote:
>> qlge TODO cited weird indentation all over qlge files, with
>> qlget_get_stats() as an example. With this fix the TODO will need to be
>> updated as well.
>>
>> This is also a re-submission, as I incorrectly sent my first patch
>> directly to the maintainers instead of to the correct mailing list.
>> Apologies.
> If you really want to fix this, I would suggest to go over all of the
> driver at once. Then you can remove the TODO entry.
I can do this. Would it be best for me to re-submit this patch in a series of patches with each indentation fix that I go through + a cover letter for the series?
next prev parent reply other threads:[~2020-02-10 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 7:36 [PATCH] staging: qlge: Fixed extra indentation in qlget_get_stats() Jarrett Knauer
2020-02-10 4:31 ` Benjamin Poirier
2020-02-10 18:31 ` Jarrett Knauer [this message]
2020-02-11 6:50 ` Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45451eb8-e6a9-2e7a-e2fd-680b31e38717@gmail.com \
--to=jrtknauer@gmail.com \
--cc=benjamin.poirier@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.