From: Patrick McHardy <kaber@trash.net>
To: Dmitry Mishin <dim@openvz.org>
Cc: Kirill Korotaev <dev@openvz.org>,
netfilter-devel@lists.netfilter.org,
Vasily Averin <vvs@openvz.org>,
devel@openvz.org
Subject: Re: [PATCH] iptables compat code error way & module refcounting fix
Date: Mon, 30 Oct 2006 17:04:43 +0100 [thread overview]
Message-ID: <4546229B.8050808@trash.net> (raw)
In-Reply-To: <200610301857.35697.dim@openvz.org>
Dmitry Mishin wrote:
> On Monday 30 October 2006 18:45, Patrick McHardy wrote:
>
>>This doesn't look right, if we fail at xt_alloc_table_info for
>>example the module references are not released.
>
> module references will be released because of 'goto out;' line just after
> xt_compat_unlock() - it is missed because of standard +-3 lines patch
> context, sorry.
You're right, I misread the code. Applied, thanks.
prev parent reply other threads:[~2006-10-30 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 10:31 [PATCH] iptables compat code error way & module refcounting fix Dmitry Mishin
2006-10-30 15:45 ` Patrick McHardy
2006-10-30 15:57 ` Dmitry Mishin
2006-10-30 16:04 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4546229B.8050808@trash.net \
--to=kaber@trash.net \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=dim@openvz.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=vvs@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.