All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Changed all calls to pci_module_init to
Date: Tue, 31 Oct 2006 03:54:20 +0000	[thread overview]
Message-ID: <4546C8EC.4020508@student.ltu.se> (raw)
In-Reply-To: <20061028201039.GB20208@zeno.unh.edu>

Ethan A Burns wrote:
>> The cleaning up of the drivers is needed, it is just the removal of 
>> pci_module_init() that needs to be left out (just to minimize the risk 
>> of people complaining it was removed ahead of time). And if you don't 
>> find anything more to do, I would appreciate any help to replace the 
>> #define FALSE/TRUE-mess we currently have in the tree with the newly (in 
>> linus-tree just before 2.6.19-rc1) added false/true (is defined in 
>> include/linux/stddef.h).
>>     
>
> I wouldn't mind doing that.  Just a simple find/replace of 'FALSE' with 'false'
> and 'TRUE' with 'true'?  
Both yes and no. Of course you can do a simple replace (like just using 
sed with "s/FALSE/false/") but I think it is a good idea to check the 
paths for the variables to see they are real booleans (only gets 'false' 
and 'true', also only used in logical operations) and also clean up 
things like "if (b = TRUE)". If you make such a patch, can you cc: me 
too, please?
>                          Even these simple (tedious) things are a good
> learning experience for me, if nothing else than to just get use to sending
> patches, etc.
>   
You got the diffstat right and there where no errors in the patch (no 
line-wrapping or etc. that I could see), so good work. :)

cu around
Richard Knutsson

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-10-31  3:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-28 20:10 [KJ] [PATCH] Changed all calls to pci_module_init to be Ethan A Burns
2006-10-30  4:16 ` [KJ] [PATCH] Changed all calls to pci_module_init to Richard Knutsson
2006-10-30 16:25 ` Ethan A Burns
2006-10-30 17:15 ` Richard Knutsson
2006-10-30 17:40 ` Ethan A Burns
2006-10-31  3:54 ` Richard Knutsson [this message]
2006-10-31  8:46 ` [KJ] [PATCH] Changed all calls to pci_module_init to be Suren Naidu
2006-11-01  1:41 ` Richard Knutsson
2006-11-01  1:46 ` eaburns
2006-11-01  2:28 ` Richard Knutsson
2006-11-01  2:31 ` Richard Knutsson
2006-11-01  4:03 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4546C8EC.4020508@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.