From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 31 Oct 2006 10:46:02 +0100 (MET) Message-ID: <45471B57.6040109@bplan-gmbh.de> From: Nicolas DET MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: [PATCH 1/2] Add MPC52xx Interrupt controller support for ARCH=powerpc References: <200610292310.k9TNAHXZ013852@post.webmailer.de> <1162268830.25682.271.camel@localhost.localdomain> <4546F68C.6070900@bplan-gmbh.de> <1162279296.25682.297.camel@localhost.localdomain> <45470006.1020004@bplan-gmbh.de> <1162281518.25682.305.camel@localhost.localdomain> <4547093E.6070502@bplan-gmbh.de> <1162284291.25682.323.camel@localhost.localdomain> <4547119C.3060208@bplan-gmbh.de> <1162285628.25682.326.camel@localhost.localdomain> In-Reply-To: <1162285628.25682.326.camel@localhost.localdomain> Content-Type: multipart/mixed; boundary="------------000006040602030902010803" Cc: linuxppc-dev@ozlabs.org, sl@bplan-gmbh.de, sha@pengutronix.de, linuxppc-embedded@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. --------------000006040602030902010803 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Benjamin Herrenschmidt wrote: >> Ok. that's why I suggest to keep buggy (or none) firmware board in >> platform specific code. > > Well, in that case, we have a well defined interface to set the sense > code, via the device-tree, and that's much better than having platform > code muck around the PIC hardware separately from the PIC driver don't > you think ? > > Anyway, that's the way it works in Linux/powerpc so there is no need > debating that for ever. Just be aware that at one point, there will be a > set_type() implementation in this driver and that it will be called > based on the polarity information in the device-tree so make sure you > got it right. > Ok. set_type() is scheduled for later on or should it be included right now? What's next should be done to finally acked the driver? >>> Of course, if your device-tree has bugs, then adding that feature >>> afterward will suddenly break efika ... >>> >> Our OpenFirmware is, of course, bugfree ;-) > > :) > You doubt? ;-) --------------000006040602030902010803 Content-Type: text/x-vcard; charset=utf-8; name="nd.vcf" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nd.vcf" begin:vcard fn:Nicolas DET ( bplan GmbH ) n:DET;Nicolas org:bplan GmbH adr:;;;;;;Germany email;internet:nd@bplan-gmbh.de title:Software Entwicklung tel;work:+49 6171 9187 - 31 x-mozilla-html:FALSE url:http://www.bplan-gmbh.de version:2.1 end:vcard --------------000006040602030902010803--