From: Nick Piggin <nickpiggin@yahoo.com.au>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Borislav Petkov <petkov@math.uni-muenster.de>,
David Rientjes <rientjes@cs.washington.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched.c : correct comment for this_rq_lock() routine
Date: Wed, 01 Nov 2006 09:46:18 +1100 [thread overview]
Message-ID: <4547D23A.3090007@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0610311250500.22528@localhost.localdomain>
Robert P. J. Day wrote:
>example, i was just poking around the source for the various
>"atomic.h" files and noticed a couple possible cleanups:
>
> 1) make sure *everyone* uses "volatile" in the typedef struct (which
> i actually submitted recently)
>
I don't see why. There is nothing in atomic (eg. atomic_read) that says
there must be a compiler barrier around the operation.
Have you checked that the architecture implementation actually needs the
volatile where you've added it?
--
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-10-31 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 21:02 [PATCH] sched.c : correct comment for this_rq_lock() routine Robert P. J. Day
2006-10-30 21:08 ` David Rientjes
2006-10-30 21:34 ` Robert P. J. Day
2006-10-30 22:05 ` Björn Steinbrink
2006-10-31 15:30 ` Borislav Petkov
2006-10-31 18:11 ` Robert P. J. Day
2006-10-31 22:46 ` Nick Piggin [this message]
2006-11-01 8:01 ` Robert P. J. Day
2006-11-01 8:13 ` Nick Piggin
2006-11-01 12:27 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4547D23A.3090007@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=petkov@math.uni-muenster.de \
--cc=rientjes@cs.washington.edu \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.