From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream-fixes] ahci: fix status register check in ahci_softreset
Date: Wed, 01 Nov 2006 04:21:06 -0500 [thread overview]
Message-ID: <45486702.5080704@pobox.com> (raw)
In-Reply-To: <20061101081918.GO13677@htj.dyndns.org>
Tejun Heo wrote:
> ahci_softreset() used to use ahci_tf_read() which reads D2H_REG area
> to check for the Status register. However, this area is zeroed on
> initialization and not set by initial signature FIS. Replace it with
> ahci_check_status().
>
> This bug prevented CLO code from being activated whenever BSY and/or
> DRQ is set prior to softreset. This fix makes
> AHCI_FLAG_RESET_NEEDS_CLO flag redundant.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied
prev parent reply other threads:[~2006-11-01 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 8:19 [PATCH #upstream-fixes] ahci: fix status register check in ahci_softreset Tejun Heo
2006-11-01 9:21 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45486702.5080704@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.