Re: [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device

[Nicolas DET <nd@bplan-gmbh.de>]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Grant Likely wrote:
> As part of the transition to arch/powerpc, this patch moves the mpc5200 PSC
> driver over to the OF platform bus infrastructure.
> 
> This patch is not acceptable for mainline as-is because it breaks arch/ppc
> support for the mpc52xx.  More rework is needed to allow it to compile for
> either arch (or alternately, fork the driver)
> 

It has been hard to apply on 2.6.19-rc4 but it seems to perform well.
I add to add some entries in mpc52xx_uart_match[]

In now looks like this:
static struct of_device_id mpc52xx_uart_match[] = {
	{
		.name = "serial",
		.compatible = "mpc52xx-psc",
	},
	{
		.name = "serial",
		.compatible = "mpc52xx-serial",
	},
	{
		.name = "serial",
		.compatible = "mpc5200-psc",
	},
	{
		.name = "serial",
		.compatible = "mpc5200-serial",
	},
	{},
};


By the way, why not using mpc52xx_uart_match[] to also in 
mpc52xx_console_setup() to track down any devices?

Regards,

[-- Attachment #2: nd.vcf --]
[-- Type: text/x-vcard, Size: 249 bytes --]

begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:nd@bplan-gmbh.de
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard