From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mo-p07-ob.rzone.de (mo-p07-ob.rzone.de [81.169.146.190]) by ozlabs.org (Postfix) with ESMTP id 9C99F67D79 for ; Thu, 2 Nov 2006 07:54:40 +1100 (EST) Date: Wed, 1 Nov 2006 21:54:37 +0100 (MET) Message-ID: <45490971.8090908@bplan-gmbh.de> From: Nicolas DET MIME-Version: 1.0 To: Grant Likely Subject: Re: [PATCH] [POWERPC] Move mpc52xx-psc uart driver to of_device from platform_device References: <11623703962380-git-send-email-grant.likely@secretlab.ca> <11623704061869-git-send-email-grant.likely@secretlab.ca> <11623704063907-git-send-email-grant.likely@secretlab.ca> <11623704071131-git-send-email-grant.likely@secretlab.ca> <1162370407105-git-send-email-grant.likely@secretlab.ca> <11623704073308-git-send-email-grant.likely@secretlab.ca> <4549056C.6080503@bplan-gmbh.de> <528646bc0611011250h6ce7d29al494ff94f891b0b07@mail.gmail.com> In-Reply-To: <528646bc0611011250h6ce7d29al494ff94f891b0b07@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------070600030105060307040709" Cc: linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. --------------070600030105060307040709 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Grant Likely wrote: > On 11/1/06, Nicolas DET wrote: >> Grant Likely wrote: >> > As part of the transition to arch/powerpc, this patch moves the >> mpc5200 PSC >> > driver over to the OF platform bus infrastructure. >> > >> > This patch is not acceptable for mainline as-is because it breaks >> arch/ppc >> > support for the mpc52xx. More rework is needed to allow it to >> compile for >> > either arch (or alternately, fork the driver) >> > >> >> It has been hard to apply on 2.6.19-rc4 but it seems to perform well. >> I add to add some entries in mpc52xx_uart_match[] > > Good news, thanks for the feedback. I take it you are able to use the > serial port with this driver? Yes. >> >> In now looks like this: >> static struct of_device_id mpc52xx_uart_match[] = { >> { >> .name = "serial", >> .compatible = "mpc52xx-psc", >> }, >> { >> .name = "serial", >> .compatible = "mpc52xx-serial", >> }, >> { >> .name = "serial", >> .compatible = "mpc5200-psc", >> }, >> { >> .name = "serial", >> .compatible = "mpc5200-serial", >> }, >> {}, >> }; > > I'd rather not do this for the mainline code. I'd rather define a > naming convention and all of us use it. We're early enough in this > process that we can do that since there are only two major boards > (lite5200 & Efika) on track to be supported in mainline ATM. > > Having 4 compatibility blocks to support 2 boards is over-engineering. :) Ok. Efika will have "mpc5200-serial' inside the "compatible" property. Regards, --------------070600030105060307040709 Content-Type: text/x-vcard; charset=utf-8; name="nd.vcf" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="nd.vcf" begin:vcard fn:Nicolas DET ( bplan GmbH ) n:DET;Nicolas org:bplan GmbH adr:;;;;;;Germany email;internet:nd@bplan-gmbh.de title:Software Entwicklung tel;work:+49 6171 9187 - 31 x-mozilla-html:FALSE url:http://www.bplan-gmbh.de version:2.1 end:vcard --------------070600030105060307040709--