From: Thomas Monjalon <thomas@monjalon.net>
To: talshn@mellanox.com
Cc: Ranjit Menon <ranjit.menon@intel.com>,
dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
dev@dpdk.org, pallavi.kadam@intel.com,
navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com,
ocardona@microsoft.com, david.marchand@redhat.com,
arybchenko@solarflare.com, bruce.richardson@intel.com,
jerinj@marvell.com, drc@linux.vnet.ibm.com, ruifeng.wang@arm.com,
konstantin.ananyev@intel.com,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: align rte_mbuf for Windows
Date: Thu, 11 Jun 2020 16:29:34 +0200 [thread overview]
Message-ID: <4549446.TvtaaPhbfP@thomas> (raw)
In-Reply-To: <20200611114316.GA12564@platinum>
11/06/2020 13:43, Olivier Matz:
> On Tue, May 19, 2020 at 03:15:19PM -0700, Ranjit Menon wrote:
> > On 5/19/2020 1:18 PM, Thomas Monjalon wrote:
> > > 19/05/2020 21:57, Dmitry Kozlyuk:
> > > > On Tue, 19 May 2020 20:49:50 +0200
> > > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > > >
> > > > > +Cc more maintainers
> > > > >
> > > > > 19/05/2020 20:41, talshn@mellanox.com:
> > > > > > From: Tal Shnaiderman <talshn@mellanox.com>
> > > > > >
> > > > > > Using uint32_t type bit-fields in Windows will pads the
> > > > > > 'L2/L3/L4 and tunnel information' union with additional bits.
> > > > > >
> > > > > > This padding causes rte_mbuf size misalignment and the total size
> > > > > > increases to 3 cache-lines.
> > > > > >
> > > > > > Changed packet_type bit-fields types from uint32_t to uint8_t
> > > > > > to allow unified 2 cache-line structure size.
> > > > > >
> > > > > > Added the __extension__ attribute over the modified struct to avoid
> > > > > > the warning:
> > > > > >
> > > > > > type of bit-field ... is a GCC extension [-pedantic]
> > > > > >
> > > > > > Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2020-06-11 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:41 [dpdk-dev] [PATCH] mbuf: align rte_mbuf for Windows talshn
2020-05-19 18:49 ` Thomas Monjalon
2020-05-19 19:57 ` Dmitry Kozlyuk
2020-05-19 20:18 ` Thomas Monjalon
2020-05-19 22:15 ` Ranjit Menon
2020-06-11 11:43 ` Olivier Matz
2020-06-11 14:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4549446.TvtaaPhbfP@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=drc@linux.vnet.ibm.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.