From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: audit-userspace: auparse/lru.c sanity_check_queue() compile error with DEBUG Date: Wed, 20 Dec 2017 16:19:42 -0500 Message-ID: <4549450.qjQlotygAB@x2> References: <0A243E67-C01F-48B4-8CC1-97CA9C29F074@illinois.edu> <20184770.acj3PY5EEU@x2> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6713555717099931288==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: "Mor, Omri" Cc: "linux-audit@redhat.com" List-Id: linux-audit@redhat.com This is a multi-part message in MIME format. --===============6713555717099931288== Content-Type: multipart/alternative; boundary="nextPart4029566.sRdGloK3if" Content-Transfer-Encoding: 7Bit This is a multi-part message in MIME format. --nextPart4029566.sRdGloK3if Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" On Tuesday, December 19, 2017 2:49:08 PM EST Mor, Omri wrote: > >> sanity_check_queue() attempts to call msg(), which as far as I can tell > >> isn=E2=80=99t defined. It appears that this should be syslog() or audi= t_msg() > >> instead. > >> This causes compilation failure when DEBUG is defined. > >=20 > > Thanks for reporting this. The function name is now fixed in git. >=20 > On second look, I think it=E2=80=99s supposed to be syslog(), not audit_m= sg(). > The rest of the code in auparse/lru.c calls syslog(), Yes, I see that now. Normally syslog is wrapped so that messages can be swi= tched=20 between stderr and syslog depending on the needs. Its fixed again in git. =2DSteve --nextPart4029566.sRdGloK3if Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="UTF-8"

On Tuesday,= December 19, 2017 2:49:08 PM EST Mor, Omri wrote:

> >&g= t; sanity_check_queue() attempts to call msg(), which as far as I can tell<= /p>

> >&g= t; isn=E2=80=99t defined. It appears that this should be syslog() or audit_= msg()

> >&g= t; instead.

> >&g= t; This causes compilation failure when DEBUG is defined.

> > <= /p>

> > T= hanks for reporting this. The function name is now fixed in git.

>

> On sec= ond look, I think it=E2=80=99s supposed to be syslog(), not audit_msg().

> The re= st of the code in auparse/lru.c calls syslog(),

&nb= sp;

Yes, I see = that now. Normally syslog is wrapped so that messages can be switched betwe= en stderr and syslog depending on the needs. Its fixed again in git.

&nb= sp;

-Steve

&nb= sp;

--nextPart4029566.sRdGloK3if-- --===============6713555717099931288== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6713555717099931288==--