Re: [PATCH] adding ROM chips to device tree

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Josh Boyer wrote:

>>+
>>+    Required properties:
>>+
>>+     - device_type : has to be "rom"

> Why "rom" instead of "NOR"?

    What does "NOR" mean -- logical operator? :-)
    I'd yet agree with "nor-flash", however, the physmap-driven device may not 
always be writeable, IIUC...

>>+     - compatible : Should be the name of the MTD driver. Currently, this is
>>+       most likely to be "physmap".
>>+     - reg : Offset and length of the register set for the device.

> reg doesn't really describe a register set here.  It's the overall
> memory space for flash.

    This is no more a standard boilerplate, if you look at this file.
    Also remember that we're not describing "physmap" compatible devices only.

>>+
>>+    Recommended properties :
>>+
>>+     - bank-width : Width of the flash data bus in bytes. Must be specified
>>+       for the NOR flashes.

> This is a required property, not a recommended one.

    Required by *certain* driver. Others may not need it (know beforehand).

> josh

WBR, Sergei