All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <Sunil.Mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Re: [Ocfs2-tools-devel] Patch for debugfs.ocfs2 ``icheck'' command
Date: Thu Nov  2 17:06:20 2006	[thread overview]
Message-ID: <454A9609.8060402@oracle.com> (raw)
In-Reply-To: <200611021638.36134.jie.gong@oracle.com>

http://oss.oracle.com/~smushran/debugfs.ocfs2-icheck-04a.patch

The comments have been inlined in the patch.

Summary;
1. Follow Tao's recommendation for checking against known holes.
The check for the first cluster group can be done before hand, and for
the remaining, it can be done as part of the group descriptor check.

2. It should allow users to provide multiple block numbers. See do_locate()
for more.

3. The output should not only accommodate multiple block#s but also
provide a little more information. For e.g., for a regular file, list the
logical block#. (The idea behind this is for users to be able to easily
map a physical block on a device to an offset in a file.) Other inode types
are easy to search thru and may not need any help. A known hole
should be marked as a HOLE. We'll clean it up later.

Other than that, it is looking good.

Sunil

GONG Jie wrote:
> Sorry for miss the file find_block_inode.h.
>
> On Thursday 02 November 2006 15:47, GONG Jie wrote:
>   
>> Hi, all
>>
>> Enclosed please find the rewrite debugfs.ocfs2 ``icheck'' patch for your
>> review.
>>     
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ocfs2-tools-devel mailing list
> Ocfs2-tools-devel@oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-tools-devel
>   

           reply	other threads:[~2006-11-02 17:06 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200611021638.36134.jie.gong@oracle.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454A9609.8060402@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.