All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Groves <John@Groves.net>
To: Vlad Apostolov <vapo@sgi.com>
Cc: jgl@johngroves.net, linux-xfs@oss.sgi.com,
	Dean Roehrich <roehrich@sgi.com>
Subject: Re: XFS dmapi: dm_path_to_handle fails if the path is a directory
Date: Thu, 02 Nov 2006 20:53:37 -0600	[thread overview]
Message-ID: <454AAF31.8050104@Groves.net> (raw)
In-Reply-To: <454AAC6B.7010406@sgi.com>

Vlad Apostolov wrote:

> Hi John,
>
> I did try this on my dmapi filesystem:
>
> emu:/mnt/scratch1/dmapi_test # mkdir -p x/y/z
> emu:/mnt/scratch1/dmapi_test # 
> /home/vapo/isms/xfs-cmds/xfstests/dmapi/src/suite1/cmd/path_to_handle x/y
> 5d1111a90e4800000e00000003000000d903400000000000
> emu:/mnt/scratch1/dmapi_test # mv x/y x/w
> emu:/mnt/scratch1/dmapi_test # 
> /home/vapo/isms/xfs-cmds/xfstests/dmapi/src/suite1/cmd/path_to_handle x/w
> 5d1111a90e4800000e00000003000000d903400000000000
> emu:/mnt/scratch1/dmapi_test #
>
> I also tried path_to_handle with relative path to a directory it 
> worked fine too. When you say
> dm_path_to_handle fails, what is the error returned?
>
> Regards,
> Vlad
>

Vlad,

This was my bad -- I need to go back to programming school ;-).

The function in question was dealing in mount-point-relative paths, not 
full paths, and I didn't notice the distinction.  Passing a full path to 
dm_path_to_handle fixed it.  As for thinking it behaved differently for 
a directory than for a file -- I've been smoking a batch of bad crack 
;-).  Calling dm_path_to_handle also failed with relative paths to files 
-- I just didn't notice because it wasn't fatal on that code path.

Thanks for responding and looking into it, though.

Regards,
John

  reply	other threads:[~2006-11-03  3:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-31 23:21 XFS dmapi: dm_path_to_handle fails if the path is a directory John Groves
2006-11-01  0:44 ` Vlad Apostolov
2006-11-01  0:57   ` Vlad Apostolov
2006-11-03  1:00   ` John Groves
2006-11-03  2:41     ` Vlad Apostolov
2006-11-03  2:53       ` John Groves [this message]
2006-11-03  2:59         ` Vlad Apostolov
2006-11-03 14:57           ` John Groves
2006-11-05 22:37             ` Vlad Apostolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454AAF31.8050104@Groves.net \
    --to=john@groves.net \
    --cc=jgl@johngroves.net \
    --cc=linux-xfs@oss.sgi.com \
    --cc=roehrich@sgi.com \
    --cc=vapo@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.