All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] To add OMAP 2430 Support
Date: Fri, 03 Nov 2006 20:03:52 +0100	[thread overview]
Message-ID: <454B9298.4080009@gmail.com> (raw)
In-Reply-To: <77C7F7CB1230A74A9D19C0C111E6EDBE01C6AEA2@DLEE09.ent.ti.com>

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Syed Mohammed, Khasim wrote:
> Attached are set of patches to get OMAP 2430 "minimal" support on to the
> tree. 
> 
> With these patches I was able to boot the kernel on 2430SDP and have
> verified booting the same on 2420 H4 (just to confirm it doesn't break
> any existing 2420 functionality).
> 
> Please do let me know for any issues,

One minor thing: Attachment removes warning about defined
but unused sdp2430_init_flash. Maybe you like to add 
sdp2430_init_flash later again if its working?

Cheers

Dirk



[-- Attachment #2: board-2430sdp_warning_fix.txt --]
[-- Type: text/plain, Size: 830 bytes --]

Index: linux-osk/arch/arm/mach-omap2/board-2430sdp.c
===================================================================
--- linux-osk.orig/arch/arm/mach-omap2/board-2430sdp.c
+++ linux-osk/arch/arm/mach-omap2/board-2430sdp.c
@@ -185,25 +185,12 @@ static inline void __init sdp2430_init_s
 
 }
 
-static void __init sdp2430_init_flash(void)
-{
-	unsigned long base;
-
-	if (gpmc_cs_request(SDP2430_FLASH_CS, SZ_64M, &base) < 0) {
-		printk("Can't request GPMC CS for flash\n");
-		return;
-	}
-	sdp2430_flash_resource.start	= base;
-	sdp2430_flash_resource.end   	= base + SZ_64M - 1;
-}
-
 static void __init omap_2430sdp_init_irq(void)
 {
 	omap2_init_common_hw();
 	omap_init_irq();
 	omap_gpio_init();
 	sdp2430_init_smc91x();
-//	2430sdp_init_flash();
 }
 
 static struct omap_uart_config sdp2430_uart_config __initdata = {


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2006-11-03 19:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-03 18:44 [PATCH] To add OMAP 2430 Support Syed Mohammed, Khasim
2006-11-03 19:03 ` Dirk Behme [this message]
2006-11-03 19:28 ` Dirk Behme
2006-11-03 22:00   ` David Brownell
2006-11-03 22:49     ` Syed Mohammed, Khasim
2006-11-09  2:23       ` Tony Lindgren
2006-11-09  2:22 ` Tony Lindgren
  -- strict thread matches above, loose matches on Subject: below --
2006-11-09 15:01 Woodruff, Richard
2006-11-10  0:46 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454B9298.4080009@gmail.com \
    --to=dirk.behme@googlemail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=x0khasim@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.