Re: Pending October patches

[Dirk Behme <dirk.behme@googlemail.com>]

David Brownell wrote:
> On Wednesday 01 November 2006 1:28 pm, tony@atomide.com wrote:
>>>27. [PATCH] [USB/CORE/USB.C] Fixes autosuspend and auto_pm 
>>>fields missing
>>>http://linux.omap.com/pipermail/linux-omap-open-source/2006-October/008234.html
>>
>>Sounds like this is getting fixed in the mainline tree.
> 
> No, the root cause of the problem is a borked h2 defconfig; but I'm
> not clear how it got past the build step that's supposed to make sure
> the current config matches all the Kconfig constraints.
> 
> (That is, USB_SUSPEND depends on PM, but only one of them was set in
> the defconfig yet the build was proceeding ...)

Just tried it, it really fails and isn't resolved by Kconfig 
processing.

Looking at h2 defconfig we have

# CONFIG_PM is not set
CONFIG_USB_SUSPEND=y
CONFIG_USB_OTG=y

Looking at drivers/usb/core/Kconfig we have

config USB_SUSPEND
	bool "USB selective suspend/resume and wakeup (EXPERIMENTAL)"
	depends on USB && PM && EXPERIMENTAL

config USB_OTG
	bool
	depends on USB && EXPERIMENTAL
	select USB_SUSPEND
	default n

So USB_SUSPEND isn't activated (processed?) because PM isn't 
set. But USB_OTG selects USB_SUSPEND without selecting PM as 
well.

Maybe anything like

--- linux-osk.orig/drivers/usb/core/Kconfig
+++ linux-osk/drivers/usb/core/Kconfig
@@ -77,6 +77,7 @@ config USB_OTG
         bool
         depends on USB && EXPERIMENTAL
         select USB_SUSPEND
+       select PM
         default n

can help here?

Cheers

Dirk