All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, shaohua.li@intel.com, bunk@stusta.de
Subject: Re: [patch] Regression in 2.6.19-rc microcode driver
Date: Mon, 06 Nov 2006 20:02:54 +0100	[thread overview]
Message-ID: <454F86DE.1040803@linux.intel.com> (raw)
In-Reply-To: <20061106110152.63ef91bc.akpm@osdl.org>

Andrew Morton wrote:
>> --- linux-2.6.18/arch/i386/kernel/microcode.c.org	2006-11-06 14:50:37.000000000 +0100
>> +++ linux-2.6.18/arch/i386/kernel/microcode.c	2006-11-06 14:52:30.000000000 +0100
>> @@ -577,7 +577,7 @@ static void microcode_init_cpu(int cpu)
>>  	set_cpus_allowed(current, cpumask_of_cpu(cpu));
>>  	mutex_lock(&microcode_mutex);
>>  	collect_cpu_info(cpu);
>> -	if (uci->valid)
>> +	if (uci->valid && system_state==SYSTEM_RUNNING)
>>  		cpu_request_microcode(cpu);
>>  	mutex_unlock(&microcode_mutex);
>>  	set_cpus_allowed(current, old);
> 
> Can we fix this by switching to late_initcall() or something like that?

I will try but it then still runs before userspace (esp "init") is 
alive so I'm not convinced it'll do the right thing

  reply	other threads:[~2006-11-06 19:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 14:15 [patch] Regression in 2.6.19-rc microcode driver Arjan van de Ven
2006-11-06 19:01 ` Andrew Morton
2006-11-06 19:02   ` Arjan van de Ven [this message]
2006-11-06 19:18   ` Arjan van de Ven
2006-11-07  1:20 ` Shaohua Li
2006-11-07  1:59   ` Andrew Morton
2006-11-07  9:13     ` Arjan van de Ven
2006-11-07  9:21       ` Andrew Morton
2006-11-07  9:35         ` Arjan van de Ven
2006-11-07  9:43         ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454F86DE.1040803@linux.intel.com \
    --to=arjan@linux.intel.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.