Re: [PATCH 2/2 #upstream] ahci: honor PORTS_IMPL on ICH8s

[Tejun Heo <htejun@gmail.com>]

Robin H. Johnson wrote:
> On Thu, Nov 02, 2006 at 12:20:59PM +0900, Tejun Heo wrote:
>> @@ -1439,7 +1453,7 @@ static int ahci_host_init(struct ata_pro
>>  	struct ahci_host_priv *hpriv = probe_ent->private_data;
>>  	struct pci_dev *pdev = to_pci_dev(probe_ent->dev);
>>  	void __iomem *mmio = probe_ent->mmio_base;
>> -	unsigned int i, using_dac;
>> +	unsigned int i, cap_n_ports, using_dac;
>>  	int rc;
>>  
>>  	rc = ahci_reset_controller(mmio, pdev);
>> @@ -1448,10 +1462,34 @@ static int ahci_host_init(struct ata_pro
>>  
>>  	hpriv->cap = readl(mmio + HOST_CAP);
>>  	hpriv->port_map = readl(mmio + HOST_PORTS_IMPL);
>> -	probe_ent->n_ports = ahci_nr_ports(hpriv->cap);
>> +	cap_n_ports = ahci_nr_ports(hpriv->cap);
>>  
>>  	VPRINTK("cap 0x%x  port_map 0x%x  n_ports %d\n",
>> -		hpriv->cap, hpriv->port_map, probe_ent->n_ports);
>> +		hpriv->cap, hpriv->port_map, n_ports);
> n_ports is undefined here. Should be cap_n_ports instead.
> 
> Other than that, the two patches work perfectly.

Thanks.  Forgot to drop that part again.  I'll post updated patch in a 
few hours.

-- 
tejun