From: Steve French <smfltc@us.ibm.com>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Theodore Tso <tytso@mit.edu>
Subject: Re: [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE_SIZE
Date: Tue, 07 Nov 2006 09:50:27 -0600 [thread overview]
Message-ID: <4550AB43.10704@us.ibm.com> (raw)
In-Reply-To: <1162913653.8123.13.camel@kleikamp.austin.ibm.com>
Dave Kleikamp wrote:
> On Tue, 2006-11-07 at 07:40 -0600, Dave Kleikamp wrote:
>
>> It would probably be best to just set stat->blksize to the negotiated
>> buffer size.
>>
>
> But be careful here. I don't know how applications/glibc may behave if
> stat->blksize is not a power of 2.
>
The man page is not particularly helpful either as it simply indicates:
"The st_blksize field gives the preferred blocksize for efficient
file system I/O. "
but it appears that blksize would affects readdir performance more than
read/write
(since read/write go through the pagecache and thus readpages/writepages
will request readahead/writebehind for many pages at a time) unless the
application
opens the file direct i/o.
next prev parent reply other threads:[~2006-11-07 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 21:50 [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE_SIZE Eric Sandeen
2006-11-06 22:27 ` Dave Kleikamp
2006-11-06 22:37 ` Eric Sandeen
2006-11-07 0:26 ` Steve French
2006-11-07 13:40 ` Dave Kleikamp
2006-11-07 15:34 ` Dave Kleikamp
2006-11-07 15:50 ` Steve French [this message]
2006-11-06 23:05 ` Christoph Hellwig
2006-11-06 23:15 ` Eric Sandeen
2006-11-06 23:17 ` Christoph Hellwig
2006-11-06 23:28 ` Eric Sandeen
2006-11-07 0:08 ` Andreas Dilger
2006-11-07 0:13 ` Hua Zhong
2006-11-07 1:39 ` Eric Sandeen
2006-11-07 3:43 ` Theodore Tso
2006-11-07 4:02 ` Eric Sandeen
-- strict thread matches above, loose matches on Subject: below --
2006-12-03 13:21 col-pepper
2006-12-03 13:48 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4550AB43.10704@us.ibm.com \
--to=smfltc@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.