From: Dirk Behme <dirk.behme@googlemail.com>
To: OMAP <Linux-omap-open-source@linux.omap.com>
Subject: [PATCH] ARM: OMAP: Fix warnings in N770 build
Date: Tue, 07 Nov 2006 17:04:03 +0100 [thread overview]
Message-ID: <4550AE73.6020007@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
Fix some warnings in n770_defconfig build:
drivers/mtd/nand/omap-hw.c:390: warning:
'omap_nand_write_byte' defined but not used
ttahvo-usb.c, tahvo-user.c and retu-user.c: ignoring return
value of 'xxx', declared with attribute warn_unused_result
Signed-off-by: Dirk Behme <dirk.behme_at_gmail.com>
[-- Attachment #2: n770_build_warning_patch.txt --]
[-- Type: text/plain, Size: 4059 bytes --]
Index: linux-osk/drivers/cbus/retu-user.c
===================================================================
--- linux-osk.orig/drivers/cbus/retu-user.c
+++ linux-osk/drivers/cbus/retu-user.c
@@ -272,6 +272,7 @@ static int retu_ioctl(struct inode *inod
unsigned int cmd, unsigned long arg)
{
struct retu_tahvo_write_parms par;
+ int ret;
switch (cmd) {
case URT_IOCT_IRQ_SUBSCR:
@@ -279,9 +280,13 @@ static int retu_ioctl(struct inode *inod
case RETU_IOCH_READ:
return retu_user_read_with_mask(arg);
case RETU_IOCX_WRITE:
- copy_from_user(&par, (void __user *) arg, sizeof(par));
+ ret = copy_from_user(&par, (void __user *) arg, sizeof(par));
+ if(ret)
+ printk(KERN_ERR "copy_from_user failed: %d\n", ret);
par.result = retu_user_write_with_mask(par.field, par.value);
- copy_to_user((void __user *) arg, &par, sizeof(par));
+ ret = copy_to_user((void __user *) arg, &par, sizeof(par));
+ if(ret)
+ printk(KERN_ERR "copy_to_user failed: %d\n", ret);
break;
case RETU_IOCH_ADC_READ:
return retu_read_adc(arg);
@@ -326,8 +331,10 @@ static ssize_t retu_read(struct file *fi
list_move(&irq->node, &retu_irqs_reserve);
spin_unlock_irqrestore(&retu_irqs_lock, flags);
- copy_to_user(buf + i * sizeof(irq_id), &irq_id, sizeof(irq_id));
-
+ ret = copy_to_user(buf + i * sizeof(irq_id), &irq_id,
+ sizeof(irq_id));
+ if(ret)
+ printk(KERN_ERR "copy_to_user failed: %d\n", ret);
}
return count;
Index: linux-osk/drivers/cbus/tahvo-usb.c
===================================================================
--- linux-osk.orig/drivers/cbus/tahvo-usb.c
+++ linux-osk/drivers/cbus/tahvo-usb.c
@@ -648,10 +648,12 @@ static int tahvo_usb_probe(struct device
}
/* Attributes */
- device_create_file(dev, &dev_attr_vbus_state);
+ ret = device_create_file(dev, &dev_attr_vbus_state);
#ifdef CONFIG_USB_OTG
- device_create_file(dev, &dev_attr_otg_mode);
+ ret |= device_create_file(dev, &dev_attr_otg_mode);
#endif
+ if(ret)
+ printk(KERN_ERR "attribute creation failed: %d\n", ret);
/* Create OTG interface */
tahvo_usb_power_off(tu);
Index: linux-osk/drivers/cbus/tahvo-user.c
===================================================================
--- linux-osk.orig/drivers/cbus/tahvo-user.c
+++ linux-osk/drivers/cbus/tahvo-user.c
@@ -256,6 +256,7 @@ static int tahvo_ioctl(struct inode *ino
unsigned int cmd, unsigned long arg)
{
struct retu_tahvo_write_parms par;
+ int ret;
switch (cmd) {
case URT_IOCT_IRQ_SUBSCR:
@@ -263,9 +264,13 @@ static int tahvo_ioctl(struct inode *ino
case TAHVO_IOCH_READ:
return tahvo_user_read_with_mask(arg);
case TAHVO_IOCX_WRITE:
- copy_from_user(&par, (void __user *) arg, sizeof(par));
+ ret = copy_from_user(&par, (void __user *) arg, sizeof(par));
+ if(ret)
+ printk(KERN_ERR "copy_from_user failed: %d\n", ret);
par.result = tahvo_user_write_with_mask(par.field, par.value);
- copy_to_user((void __user *) arg, &par, sizeof(par));
+ ret = copy_to_user((void __user *) arg, &par, sizeof(par));
+ if(ret)
+ printk(KERN_ERR "copy_to_user failed: %d\n", ret);
break;
default:
return -ENOIOCTLCMD;
@@ -308,7 +313,10 @@ static ssize_t tahvo_read(struct file *f
list_move(&irq->node, &tahvo_irqs_reserve);
spin_unlock_irqrestore(&tahvo_irqs_lock, flags);
- copy_to_user(buf + i * sizeof(irq_id), &irq_id, sizeof(irq_id));
+ ret =copy_to_user(buf + i * sizeof(irq_id), &irq_id,
+ sizeof(irq_id));
+ if(ret)
+ printk(KERN_ERR "copy_to_user failed: %d\n", ret);
}
return count;
Index: linux-osk/drivers/mtd/nand/omap-hw.c
===================================================================
--- linux-osk.orig/drivers/mtd/nand/omap-hw.c
+++ linux-osk/drivers/mtd/nand/omap-hw.c
@@ -386,11 +386,6 @@ static u_char omap_nand_read_byte(struct
return nand_read_reg8(NND_ACCESS);
}
-static void omap_nand_write_byte(struct mtd_info *mtd, u_char byte)
-{
- nand_write_reg8(NND_ACCESS, byte);
-}
-
static int omap_nand_dev_ready(struct mtd_info *mtd)
{
u32 l;
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2006-11-07 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 16:04 Dirk Behme [this message]
2006-11-11 0:05 ` [PATCH] ARM: OMAP: Fix warnings in N770 build Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4550AE73.6020007@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=Linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.