All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot?
Date: Tue, 07 Nov 2006 11:24:37 -0600	[thread overview]
Message-ID: <4550C155.2030202@freescale.com> (raw)
In-Reply-To: <455066B3.1090302@orkun.us>

Tolunay Orkun wrote:
> Here is the patch (attached) that handles top boot geometry reversal 
> case on AMD flash.

This patch works for me, so I approve it.  I tested it on the board that has 
this problem, as well as an 8360-based board that has only same-sized sectors.

Just one nit:

Adds trailing whitespace.
.dotest/patch:35:               man_id = flash_read_uchar (info,
Adds trailing whitespace.
.dotest/patch:37:               dev_id = flash_read_uchar(info,
warning: 2 lines add trailing whitespaces.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2006-11-07 17:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 23:46 [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot? timur at freescale.com
2006-11-07  0:51 ` Tolunay Orkun
2006-11-07  1:09 ` [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check fortop/bottom boot? Spence Nick-rxtd10
2006-11-07 10:57 ` [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot? Tolunay Orkun
2006-11-07 17:24   ` Timur Tabi [this message]
2006-11-07 18:01     ` Tolunay Orkun
2006-11-07 18:16       ` Stefan Roese
2006-11-07 23:05         ` Tolunay Orkun
2006-11-07 23:19         ` Tolunay Orkun
2006-11-07 17:50   ` Spence Nick-rxtd10
2006-11-07 18:14     ` Tolunay Orkun
2006-11-07 18:38       ` Timur Tabi
2006-11-07 18:46         ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4550C155.2030202@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.