From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sshtylyov@ru.mvista.com>
Received: from imap.sh.mvista.com (unknown [63.81.120.155])
	by ozlabs.org (Postfix) with ESMTP id C929D67CBC
	for <linuxppc-embedded@ozlabs.org>;
	Wed,  8 Nov 2006 05:30:14 +1100 (EST)
Message-ID: <4550D0A2.90509@ru.mvista.com>
Date: Tue, 07 Nov 2006 21:29:54 +0300
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MIME-Version: 1.0
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>, Vitaly Wool <vwool@ru.mvista.com>
Subject: Re: [PATCH] adding ROM chips to device tree
References: <20061102145539.f0b8657f.vwool@ru.mvista.com>	<1162474237.11351.7.camel@zod.rchland.ibm.com>
	<454A4266.8040505@ru.mvista.com>
In-Reply-To: <454A4266.8040505@ru.mvista.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Cc: linuxppc-embedded@ozlabs.org
List-Id: Linux on Embedded PowerPC Developers Mail List
	<linuxppc-embedded.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-embedded>,
	<mailto:linuxppc-embedded-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-embedded>
List-Post: <mailto:linuxppc-embedded@ozlabs.org>
List-Help: <mailto:linuxppc-embedded-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-embedded>,
	<mailto:linuxppc-embedded-request@ozlabs.org?subject=subscribe>

Sergei Shtylyov wrote:
> Hello.
> 
> Josh Boyer wrote:
> 
> 
>>>+
>>>+    Required properties:
>>>+
>>>+     - device_type : has to be "rom"

>>Why "rom" instead of "NOR"?

>     What does "NOR" mean -- logical operator? :-)
>     I'd yet agree with "nor-flash", however, the physmap-driven device may not 
> always be writeable, IIUC...

    Hence an idea: maybe we need to introduce the "writeable" property (just a 
logical value, i.e. absent/resent)?

>>>+     - compatible : Should be the name of the MTD driver. Currently, this is
>>>+       most likely to be "physmap".
>>>+     - reg : Offset and length of the register set for the device.

>>reg doesn't really describe a register set here.  It's the overall
>>memory space for flash.

    Since "reg" property is the way for device to claim its I/O resources, it 
must be used to describe the decoded memory range, I think. Maybe I should 
have added a comment about its meaning for direct mapped devices in the first 
place...

>     This is no more a standard boilerplate, if you look at this file.

    No more than a boilerplate, I meant to say.

WBR, Sergei