From: Jeff Garzik <jgarzik@pobox.com>
To: Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>
Cc: Greg KH <gregkh@suse.de>, Martin Bligh <mbligh@mbligh.org>,
Badari Pulavarty <pbadari@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
sukadev@us.ibm.com
Subject: Re: [PATCH] pci device ensure sysdata initialised v2
Date: Wed, 08 Nov 2006 06:22:25 -0500 [thread overview]
Message-ID: <4551BDF1.7050302@pobox.com> (raw)
In-Reply-To: <2026c73e8887d52443f750c2885a9f2e@pinky>
Andy Whitcroft wrote:
> Ok, I've gone over the patches and retested them. Other than having
> to extend them to cover x86_64 they still seem to work as planned. I
> have updated the commentry to better explain the problem and the
> fix as encapsulated here.
>
> When this was proposed last time there was push back to get the
> nodes right. Whist this is clearly a good thing, I think we need
> this as a first step if the underlying patches are going to stay
> in.
We definitely need something like this. Having some sysdata static and
some sysdata dynamic makes me nervous, and so I want to review the code
paths in depth before applying this. My gut feeling is that there is a
bug remaining in this area, that this patch might exacerbate.
Jeff
prev parent reply other threads:[~2006-11-08 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-08 7:02 Panic in pci_call_probe from 2.6.18-mm2 and 2.6.18-mm3 Martin J. Bligh
2006-10-08 7:49 ` Andrew Morton
2006-10-09 17:19 ` Badari Pulavarty
2006-10-09 17:24 ` Martin Bligh
2006-10-09 17:34 ` Jeff Garzik
2006-10-09 18:46 ` Sukadev Bhattiprolu
2006-10-20 17:07 ` Andy Whitcroft
2006-10-20 17:37 ` Greg KH
2006-11-01 14:37 ` [PATCH] pci device ensure sysdata initialised v2 Andy Whitcroft
2006-11-08 11:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4551BDF1.7050302@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=pbadari@us.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.