All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Luugi Marsan <luugi.marsan@amd.com>
Cc: linux-kernel@vger.kernel.org,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH 2/2] Workaround for SB600 SATA ODD issue
Date: Wed, 08 Nov 2006 08:30:25 -0500	[thread overview]
Message-ID: <4551DBF1.2080609@garzik.org> (raw)
In-Reply-To: <20061103190004.9ED8DCBD48@localhost.localdomain>

Luugi Marsan wrote:
> From: conke.hu@amd.com
> 
> There was an ASIC bug in the SB600 SATA controller of low revision (<=13) and CD burning may hang (only SATA ODD has this issue, and SATA HDD works well). The patch provides a workaround for this issue.
> 
> Signed-off-by:  Luugi Marsan <luugi.marsan@amd.com>

ACK technical content, but it needs one revision:  like someone else 
(Alan or Tejun?) mentioned, this patch should be revised to use a 
separate ata_port_operations for the affected chip(s).

Copy ahci_ops to sb600_ops, add your check-atapi-dma function without 
the vendor/device ID check.  Move the vendor/device check to the 
pci_device_id table by creating a board_ahci_sb600 constant and 
associated table data.

I agree with other posters that we should move the revision check to 
more generic code, but such a move should not block this patch.  The two 
efforts can occur in parallel.

	Jeff



      parent reply	other threads:[~2006-11-08 13:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-03 19:00 [PATCH 2/2] Workaround for SB600 SATA ODD issue Luugi Marsan
2006-11-04 12:52 ` Christoph Hellwig
2006-11-04 17:36 ` Arjan van de Ven
2006-11-04 18:35   ` Christoph Hellwig
2006-11-05 12:45   ` Conke Hu
2006-11-06 12:14 ` Tejun Heo
2006-11-08 13:30 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4551DBF1.2080609@garzik.org \
    --to=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luugi.marsan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.