All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Martin Devera <devik@cdi.cz>
Cc: linux-ide@vger.kernel.org
Subject: Re: sata_via broken in 2.6.19rc4
Date: Wed, 08 Nov 2006 08:32:35 -0500	[thread overview]
Message-ID: <4551DC73.9070506@pobox.com> (raw)
In-Reply-To: <45510A58.1040300@cdi.cz>

Martin Devera wrote:
> Hi,
> 
> it seems there is typo in sata_via.c (see ATA_PFLAG_LOADING constant 
> usage):
> 
> static int vt6420_prereset(struct ata_port *ap)
> {
>         struct ata_eh_context *ehc = &ap->eh_context;
>         unsigned long timeout = jiffies + (HZ * 5);
>         u32 sstatus, scontrol;
>         int online;
> 
>         /* don't do any SCR stuff if we're not loading */
>         if (!ATA_PFLAG_LOADING)
>                 goto skip_scr;

thanks for spotting this, fix pushed



      reply	other threads:[~2006-11-08 13:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-07 22:36 sata_via broken in 2.6.19rc4 Martin Devera
2006-11-08 13:32 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4551DC73.9070506@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=devik@cdi.cz \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.