From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci quirks: Sort out the VIA mess once and for all (hopefully)
Date: Wed, 08 Nov 2006 12:58:38 -0500 [thread overview]
Message-ID: <45521ACE.9050606@garzik.org> (raw)
In-Reply-To: <1163003156.23956.40.camel@localhost.localdomain>
Alan Cox wrote:
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc4-mm1/include/linux/libata.h linux-2.6.19-rc4-mm1/include/linux/libata.h
> --- linux.vanilla-2.6.19-rc4-mm1/include/linux/libata.h 2006-10-31 21:11:50.000000000 +0000
> +++ linux-2.6.19-rc4-mm1/include/linux/libata.h 2006-11-07 10:07:10.000000000 +0000
> @@ -109,11 +109,6 @@
> /* defines only for the constants which don't work well as enums */
> #define ATA_TAG_POISON 0xfafbfcfdU
>
> -/* move to PCI layer? */
> -#define PCI_VDEVICE(vendor, device) \
> - PCI_VENDOR_ID_##vendor, (device), \
> - PCI_ANY_ID, PCI_ANY_ID, 0, 0
> -
> static inline struct device *pci_dev_to_dev(struct pci_dev *pdev)
> {
nit: don't remove the "move to PCI layer?" comment, it also applies to
code below that which you are moving.
Patch overall seems sane to me.
Jeff
next prev parent reply other threads:[~2006-11-08 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 16:25 [PATCH] pci quirks: Sort out the VIA mess once and for all (hopefully) Alan Cox
2006-11-08 17:58 ` Jeff Garzik [this message]
2006-11-08 19:57 ` [PATCH] pci quirks: Sort out the VIA mess once and for all ?(hopefully) Luca Tettamanti
2006-11-08 20:04 ` [PATCH] pci quirks: Sort out the VIA mess once and for all (hopefully) Daniel Drake
2006-11-08 20:39 ` Alan Cox
2006-11-09 1:18 ` Sergio Monteiro Basto
2007-04-14 13:22 ` Sergio Monteiro Basto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45521ACE.9050606@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.