From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Jan Beulich <jbeulich@novell.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] i386: make BUG() expansion look like instruction
Date: Wed, 08 Nov 2006 12:43:04 -0800 [thread overview]
Message-ID: <45524158.7040301@goop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0611081733300.5025@blonde.wat.veritas.com>
Hugh Dickins wrote:
> On Wed, 8 Nov 2006, Jan Beulich wrote:
>
>> This gets i386's handle_BUG() in sync with x86-64's, namely introducing
>> a 'struct bug_frame' and arranging for the code generated by the BUG()
>> macro to represent an instruction, so that disassembling code
>> containing such constructs doesn't produce garbage anymore. The
>> resulting increase of code size is marginal (1 byte per instance).
>>
>
> I thought we were heading towards merging Jeremy's generic-bug-*
> (with file and line in another section), in -mm for a while now?
>
That's certainly my impression. Andrew already NAKed my original patch
which did something similar to Jan's, in favour of making the powerpc
BUG handling code generic. I'm hoping the generic bug can be put in
mainline fairly soon, and then encourage other arch maintainers to use it.
I think there's still some question in the air over powerpc's use of the
generic bug stuff, but as far as I know Andrew is the only person to
have a problem with it.
J
prev parent reply other threads:[~2006-11-08 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-08 16:26 [PATCH] i386: make BUG() expansion look like instruction Jan Beulich
2006-11-08 17:41 ` Hugh Dickins
2006-11-08 20:43 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45524158.7040301@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.