All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos
Date: Wed, 08 Nov 2006 16:15:46 -0600	[thread overview]
Message-ID: <45525712.8020103@acm.org> (raw)
In-Reply-To: <20061108220925.GB4972@martell.zuzino.mipt.ru>

Ouch, I guess we've never had a system with these address types.  Thanks.

-Corey

Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
>  drivers/char/ipmi/ipmi_si_intf.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1211,7 +1211,7 @@ static void intf_mem_outb(struct si_sm_i
>  static unsigned char intf_mem_inw(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readw((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void intf_mem_outw(struct si_sm_io *io, unsigned int offset,
> @@ -1223,7 +1223,7 @@ static void intf_mem_outw(struct si_sm_i
>  static unsigned char intf_mem_inl(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readl((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void intf_mem_outl(struct si_sm_io *io, unsigned int offset,
> @@ -1236,7 +1236,7 @@ #ifdef readq
>  static unsigned char mem_inq(struct si_sm_io *io, unsigned int offset)
>  {
>  	return (readq((io->addr)+(offset * io->regspacing)) >> io->regshift)
> -		&& 0xff;
> +		& 0xff;
>  }
>  
>  static void mem_outq(struct si_sm_io *io, unsigned int offset,
>   


  reply	other threads:[~2006-11-08 22:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08 22:09 [PATCH] ipmi_si_intf.c: fix "&& 0xff" typos Alexey Dobriyan
2006-11-08 22:15 ` Corey Minyard [this message]
2006-11-09  4:49   ` Valdis.Kletnieks
2006-11-09 14:45     ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45525712.8020103@acm.org \
    --to=minyard@acm.org \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.