From: Steven Rostedt <srostedt@redhat.com>
To: Keir Fraser <keir@xensource.com>
Cc: Wilfred Yu <wilfred.yu@intel.com>,
Xiaohui Xin <xiaohui.xin@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Susie Li <susie.li@intel.com>, "Li, Xin B" <xin.b.li@intel.com>,
Herbert Xu <herbert.xu@redhat.com>
Subject: Re: [Patch] Fix for x86_64 boot failures due to bad segment setup for protected mode.
Date: Thu, 09 Nov 2006 09:28:35 -0500 [thread overview]
Message-ID: <45533B13.6030904@redhat.com> (raw)
In-Reply-To: <C178E6D1.438A%keir@xensource.com>
Keir Fraser wrote:
> On 9/11/06 12:56, "Steven Rostedt" <srostedt@redhat.com> wrote:
>
>> The old approach would just update all the selectors if they fit inside
>> the GDT table, whether or not they were changed or loaded. So when Linux
>> had a bad (extremely large) GDT limit, we loaded all the selectors into
>> the shadow selector, even though they were bogus.
>
> A smaller patch might have been to implement those VMENTER sanity checks
> inside load_seg(). I'm sure they're quite simple. However, this new approach
> is arguably saner than the old, and it's worked on a few images I've tested
> it with, so I checked it in and we'll see how it holds up under wider
> testing.
>
I believed Stephen looked at the sanity check approach, and determined
that the code to simulate the sanity checks would be quite complex and
error prone. But Stephen can correct me if I'm wrong.
-- Steve
next parent reply other threads:[~2006-11-09 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C178E6D1.438A%keir@xensource.com>
2006-11-09 14:28 ` Steven Rostedt [this message]
2006-11-09 17:31 ` [Patch] Fix for x86_64 boot failures due to bad segment setup for protected mode Stephen C. Tweedie
2006-11-09 3:49 Stephen C. Tweedie
2006-11-09 8:56 ` Keir Fraser
2006-11-09 12:32 ` Stephen C. Tweedie
2006-11-09 12:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45533B13.6030904@redhat.com \
--to=srostedt@redhat.com \
--cc=herbert.xu@redhat.com \
--cc=keir@xensource.com \
--cc=susie.li@intel.com \
--cc=wilfred.yu@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=xiaohui.xin@intel.com \
--cc=xin.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.