From: Eric Sandeen <sandeen@sandeen.net>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@osdl.org
Subject: Re: [PATCH 2/3] new_inode_autonum: convert filesystems to use new function
Date: Thu, 09 Nov 2006 11:16:32 -0600 [thread overview]
Message-ID: <45536270.2040505@sandeen.net> (raw)
In-Reply-To: <1163085883.21469.46.camel@dantu.rdu.redhat.com>
Jeff Layton wrote:
> This patch converts all in-tree filesystems that blindly use the i_ino
> value given by new_inode to use new_inode_autonum. Also fix up a few
> other cases where i_ino might not end up being unique.
After looking at this, since you have to change all of these filesystems
anyway, I'm not sure there's a lot of value in having
new_inode_autonum(); they all previously called new_inode() and then
filled in a few fields of the new inode. Why not just call new_inode(),
and add a call to inode->i_inum = iunique(sb, 0)? We don't have
new_inode_autouid() or new_inode_autoatime(), why is i_ino special in
this regard?
-Eric
prev parent reply other threads:[~2006-11-09 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 15:24 [PATCH 2/3] new_inode_autonum: convert filesystems to use new function Jeff Layton
2006-11-09 15:24 ` Jeff Layton
2006-11-09 17:16 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45536270.2040505@sandeen.net \
--to=sandeen@sandeen.net \
--cc=akpm@osdl.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.