Re: new code; iptables-xml for iptables package.

[Amin Azez <azez@ufomechanic.net>]

* Patrick McHardy wrote, On 10/11/06 14:42:
> Amin Azez wrote:
>> * Patrick McHardy wrote, On 10/11/06 13:51:
>>
>>> Amin Azez wrote:
>>>
>>>> As for the spacing - guilt - I used the wrong indent options obviously
>>>> :-) fixed now
>>> Thanks, now all I need is a patch to the Makefile to actually compile
>>> this thing :)
> 
> Thanks. Compiling gives me a warning about an unused result of this
> expression:
> 
> static void
> xmlEncode(char *text)
> {
> ...
>                 *text++;
> 
> }
> 
> I assume this should be "text++"?

Oh! Certainly!

In trying to work out why it works at all, I discover that
*text++ is not the same as (*text)++; both of which are wrong in this case.

While we are at it we should make that compare at the top of the same
function be >=127 not >127

Sam