From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: new code; iptables-xml for iptables package. Date: Fri, 10 Nov 2006 16:11:37 +0100 Message-ID: <455496A9.1050208@trash.net> References: <455311B5.5000600@ufomechanic.net> <455374BE.9050507@trash.net> <455457C8.4030205@ufomechanic.net> <45547982.2070606@trash.net> <45547E94.1040100@ufomechanic.net> <455483D9.6090003@trash.net> <45548CD2.5090407@ufomechanic.net> <45548FC7.1080702@trash.net> <455493CB.4020501@ufomechanic.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Harald Welte , Netfilter Development Mailinglist Return-path: To: Amin Azez In-Reply-To: <455493CB.4020501@ufomechanic.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Amin Azez wrote: > In trying to work out why it works at all, I discover that > *text++ is not the same as (*text)++; both of which are wrong in this case. > > While we are at it we should make that compare at the top of the same > function be >=127 not >127 OK, both fixed and applied. Please send potential fixes or changes as patches against current SVN.