From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Alexis Bruemmer <alexisb@us.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/4] aic94xx: cleanup after a discovery error
Date: Fri, 10 Nov 2006 16:42:13 -0800 [thread overview]
Message-ID: <45551C65.6000000@us.ibm.com> (raw)
In-Reply-To: <1163102636.6521.19.camel@localhost.localdomain>
Alexis Bruemmer wrote:
> One question that remains with this patch is whether or not
> sas_get_port_device should be moved into sas_discover_{sas,expander} to
> ensure that the rphy struct is allocated and freed-in-error in the same
> function
It looks as though we could move the parts of sas_get_port_device() that
deal with rphy allocation/initialization into the
sas_discover_{sata,sas,expander} functions? I don't know for sure; I
could be missing some subtlety that requires the sas_rphy creation to be
in sas_get_port_device.
--D
next prev parent reply other threads:[~2006-11-11 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 20:03 [PATCH 3/4] aic94xx: cleanup after a discovery error Alexis Bruemmer
2006-11-11 0:42 ` Darrick J. Wong [this message]
2006-11-11 0:45 ` Darrick J. Wong
2006-11-12 18:31 ` Darrick J. Wong
2006-11-11 0:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45551C65.6000000@us.ibm.com \
--to=djwong@us.ibm.com \
--cc=alexisb@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.