From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] remove unused filp from ioctl functions
Date: Sat, 11 Nov 2006 11:12:35 -0600 [thread overview]
Message-ID: <45560483.5000303@sandeen.net> (raw)
In-Reply-To: <20061111105627.GB3356@infradead.org>
Christoph Hellwig wrote:
> On Fri, Nov 10, 2006 at 09:28:59PM -0600, Eric Sandeen wrote:
>> There's a stuct file * passed around the ioctl code that is never
>> used... just takes up precious stack space near as I can tell :)
>
> While you're at it kill the inode paramater anyway, it can be retrieved
> from the vnode by trivial address arithmetics.
Hadn't noticed, let me look into that.
-Eric
prev parent reply other threads:[~2006-11-11 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 3:28 [PATCH] remove unused filp from ioctl functions Eric Sandeen
2006-11-11 10:56 ` Christoph Hellwig
2006-11-11 17:12 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45560483.5000303@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.