From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: ltuikov@yahoo.com, mike.redan@bell.ca,
James.Bottomley@SteelEye.com, alexisb@us.ibm.com,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: Aic94xx and Linux kernel 2.6.19
Date: Mon, 13 Nov 2006 17:53:42 -0800 [thread overview]
Message-ID: <455921A6.8080102@us.ibm.com> (raw)
In-Reply-To: <45577499.1010101@garzik.org>
Jeff Garzik wrote:
> I'll queue it, but let me know results from your testing regardless.
I no longer see disk errors; it looks like the commands are being
retried at some point in the future, as I'd expect.
However, now I periodically see this:
BUG: warning at drivers/ata/libata-core.c:4597/ata_qc_issue()
One cause of this is that sas_ata was writing the aic94xx sequencer's
version of sactive into the libata's ata_port->sactive shadow register.
Since we now know that aic94xx assigns its own NCQ tags, the solution
is to avoid this copy, since libata manages ata_port->sactive anyway.
Unfortunately, even with that patched up I still see the message, but
only about 10% as frequently as I used to. I suspect that I haven't the
right locking around ata_sas_queuecmd and ata_qc_complete; I'm testing
that fix overnight.
--D
prev parent reply other threads:[~2006-11-14 1:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D0A3E3121A0504EAEF0FBA7B9576C2608015A07@toroondc914.bell.corp.bce.ca>
2006-11-10 23:53 ` Aic94xx and Linux kernel 2.6.19 Darrick J. Wong
2006-11-11 1:21 ` Luben Tuikov
2006-11-12 19:05 ` Darrick J. Wong
2006-11-12 19:23 ` Jeff Garzik
2006-11-14 1:53 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455921A6.8080102@us.ibm.com \
--to=djwong@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=alexisb@us.ibm.com \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=mike.redan@bell.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.