All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: "Amit S. Kale" <amitkale@netxen.com>
Cc: netdev@vger.kernel.org, Sanjeev Jorapur <sanjeev@netxen.com>,
	Rob Mapes <rob@netxen.com>,
	wendyx@us.ibm.com, brazilnut@us.ibm.com,
	netxenproj@linsyssoft.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver
Date: Tue, 14 Nov 2006 10:26:58 -0500	[thread overview]
Message-ID: <4559E042.6080100@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0611070835060.26206@dut39>

Amit S. Kale wrote:
> 
> Signed-off-by: Amit S. Kale <amitkale@netxen.com>

ACK technical content, but git-applymbox claims the patches are corrupted.

Also, please realize that your email subject line is used as a one-line 
summary for your change, copied directly into the kernel change log. 
ref http://linux.yyz.us/patch-format.html

As such, having two patches with the identical subject "NetXen: 1G/10G 
Ethernet Driver updates" is bad form, because it is overly vague, and 
fails to adequately summarize the changeset.

Example summaries:
patch #2: NetXen: temp monitoring, de-bloat, support newer firmware
patch #3: NetXen: driver cleanup, 64-bit memory fixes


  parent reply	other threads:[~2006-11-14 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-07 16:33 [PATCH 0/3] NetXen: 1G/10G Ethernet Driver updates Amit S. Kale
2006-11-07 16:38 ` [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver Amit S. Kale
2006-11-07 16:49   ` Ingo Oeser
2006-11-08  6:07     ` Amit S. Kale
2006-11-14 15:26   ` Jeff Garzik [this message]
2006-11-07 16:44 ` [PATCH 2/3] NetXen: 1G/10G Ethernet Driver updates Amit S. Kale
2006-11-07 17:02 ` [PATCH 3/3] " Amit S. Kale
  -- strict thread matches above, loose matches on Subject: below --
2006-11-17 15:25 [PATCH 1/3] NetXen: Fixed /sys mapping between device and driver Linsys Contractor Amit S. Kale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4559E042.6080100@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=amitkale@netxen.com \
    --cc=brazilnut@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=netxenproj@linsyssoft.com \
    --cc=rob@netxen.com \
    --cc=sanjeev@netxen.com \
    --cc=wendyx@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.