From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: CONFIG_XEN_COMPAT_030002 broken? Date: Tue, 14 Nov 2006 16:35:18 +0100 Message-ID: <4559E236.7080706@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Xen devel list , Jan Beulich List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > Kernel_pages_need_user_flag seems unnecessary. The one consumer of that flag > could simply do 'flags |= kernel_page_user' unconditionally. Yep, noticed that too meanwhile ;) > Also, is it necessary to default to 3.0.2 behaviour? I've started coding it that way before I found the final place for the test, just to be sure it doesn't crash on pgtable ops before the test. Defaulting to 3.0.3 behavior should work though as test happens early enough. > So far we have maintained the COMPAT code to be easily entirely strippable. > So the change to pmd_bad() should either use kernel_page_user rather than > _PAGE_USER, or its definition should be conditional on the COMPAT flag. Both ways should have the same effect as kernel_page_user is defined to 0 for the non-compat case. cheers, Gerd -- Gerd Hoffmann http://www.suse.de/~kraxel/julika-dora.jpeg