From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/5] libata: sync result_tf.flags w/ command tf.flags
Date: Tue, 14 Nov 2006 14:33:48 -0500 [thread overview]
Message-ID: <455A1A1C.40209@pobox.com> (raw)
In-Reply-To: <11635114553644-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> libata didn't initialize result_tf.flags which indicates transfer type
> (RW/FUA) and address type (CHS/LBA/LBA48). ata_gen_fixed_sense()
> assumed result_tf.flags equals command tf.flags and failed to report
> the first failed block to SCSI layer because zero tf flags indicates
> CHS and bad block reporting for CHS is not implemented.
>
> Implement fill_result_tf() which sets result_tf.flags to command
> tf.flags and use it to fill result_tf.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
applied patches 1-5
consider combining patch #4 and patch #5, when a similar situation
arises in the future
next prev parent reply other threads:[~2006-11-14 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-14 13:37 [PATCHSET] libata: improve sense data generation Tejun Heo
2006-11-14 13:37 ` [PATCH 5/5] libata: improve SCSI " Tejun Heo
2006-11-14 13:37 ` [PATCH 1/5] libata: sync result_tf.flags w/ command tf.flags Tejun Heo
2006-11-14 19:33 ` Jeff Garzik [this message]
2006-11-14 13:37 ` [PATCH 2/5] libata: fix passthru sense data header Tejun Heo
2006-11-14 13:37 ` [PATCH 4/5] libata: implement ata_tf_read_block() Tejun Heo
2006-11-14 13:37 ` [PATCH 3/5] libata: cosmetic changes to sense generation functions Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455A1A1C.40209@pobox.com \
--to=jgarzik@pobox.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.