All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, zambrano@broadcom.com, netdev@vger.kernel.org
Subject: Re: [TG3]: Increase 5906 firmware poll time.
Date: Tue, 14 Nov 2006 18:05:28 -0500	[thread overview]
Message-ID: <455A4BB8.8060301@garzik.org> (raw)
In-Reply-To: <1163544143.4954.19.camel@rh4>

Michael Chan wrote:
> [TG3]: Increase 5906 firmware poll time.
> From: Gary Zambrano <zambrano@broadcom.com>
> 
> Newer 5906 bootcode needs about 7ms to finish resetting so the poll
> firmware loop was changed to maximum 20ms.
> 
> Signed-off-by: Gary Zambrano <zambrano@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>

ACK, of course, but this brings up something else:  what's the status of 
moving chip reset outside of a spinlock?

Currently a reset during operation can trigger the CPU lockup detector 
and other doo-dads, because you can easily spend a second or two with a 
spinlock held (a loooooong time, to hold a spinlock)

	Jeff



  reply	other threads:[~2006-11-14 23:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-14 22:42 [TG3]: Increase 5906 firmware poll time Michael Chan
2006-11-14 23:05 ` Jeff Garzik [this message]
2006-11-15  0:05   ` Michael Chan
2006-11-15  0:34     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455A4BB8.8060301@garzik.org \
    --to=jeff@garzik.org \
    --cc=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=zambrano@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.