From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reuben Farrelly Subject: Re: 2.6.19-rc5-mm2 Date: Wed, 15 Nov 2006 21:42:19 +1100 Message-ID: <455AEF0B.1040907@reub.net> References: <20061114014125.dd315fff.akpm@osdl.org> <4559A91C.10009@reub.net> <20061114170053.GA22649@in.ibm.com> <20061114205829.GC2504@inferi.kami.home> <20061115103419.GA3131@in.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061115103419.GA3131@in.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: ego@in.ibm.com Cc: Andrew Morton , davej@redhat.com, linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com, CPUFreq Mailing List Hi, On 15/11/2006 9:34 PM, Gautham R Shenoy wrote: > Hi, > > On Tue, Nov 14, 2006 at 09:58:29PM +0100, Mattia Dongili wrote: >> maybe this helps? mostly guessing here, but when cpufreq_userspace is >> the default governor we may hit this path and leave policy->cur >> unset. > > I doubt if that's causing the problem. My reasons are: Yes. I just tried with the one-liner from Mattia as below, and unfortunately it made no difference. The crash was the same.. Unfortunately I didn't get to test out 2.6.19-rc5-mm1 as there was some issue with it unable to mount my ext3/raid-1 root (fixed in -rc5-mm2), that I didn't have time to get to the bottom of. So there is a chance that this cpufreq problem is not new to -rc5-mm2. Reuben > - Reuben's config shows his system to be a x64_64. So if I am not > mistaken, the correct file look for would be > arch/ia64/kernel/cpufreq/acpi-cpufreq.c. > > - The fix provided by you deals with the state of a > driver(hardware) specific variable data->cpu_feature while the > governors like userspace/performance/powersave/ondemand are > driver(hardware) independent. > > Nevertheless, it could be a valid fix for i386 acpi_cpufreq considering > that policy->cur is not being initialized if > data->cpu_feature == ACPI_ADR_SPACE_FIXED_HARDWARE. > > Please check with Dave Jones or Venkatesh Pallipadi. > > Thanks > gautham. > >> diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c >> index 18f4715..94e6e86 100644 >> --- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c >> +++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c >> @@ -706,7 +706,7 @@ static int acpi_cpufreq_cpu_init(struct >> break; >> case ACPI_ADR_SPACE_FIXED_HARDWARE: >> acpi_cpufreq_driver.get = get_cur_freq_on_cpu; >> - get_cur_freq_on_cpu(cpu); >> + policy->cur = get_cur_freq_on_cpu(cpu); >> break; >> default: >> break; >> >> -- >> mattia